migrate from CI api key to CI auth token #12
Conversation
Moto Integration Tests against LocalStack Results0 files - 1 0 suites - 1 0s ⏱️ - 5h 17m 57s Results for commit 966ac93. ± Comparison against base commit 4c0c7c4. ♻️ This comment has been updated with latest results. |
|
FYI: I cancelled the pipeline run after the startup was successful (to avoid burning 5 hours of compute). |
There was a problem hiding this comment.
We should change
localstack-moto-test-coverage/conftest.py
Line 122 in 4c0c7c4
Honestly, I do not see much value in setting the api key or auth token manually there anyway, as
os.system should inherit the environment from the parent process.
|
Thanks a lot, @dfangl! An incredibly good catch! 🚀 💯 |
There was a problem hiding this comment.
It's fine to keep it in, should not change anything! (We are literally taking an environment variable from the environment and assigning it to the same name). It is fine to keep it in for clarity.
I rerun the run to get at least one restart of LS in the run (yours was cancelled a tad to early), I will cancel it once I see LS restart once
|
The automatic restarts look good, ready to go from my side! |
Motivation
With LocalStack 4.0.0, API keys have been fully migrated to auth tokens by also providing CI auth tokens.
This PR switches to using a new CI auth token instead of the old CI API key in the pipeline.
Changes
/cc @SimonWallner @ackdav